A better Rust ATProto crate
add streaming methods to HttpClient
author
Orual
date
(Oct 15, 2025, 1:57 PM -0400)
commit
0b3a649c
0b3a649c17921e74d67e9e4c4e002749c66cf697
parent
cce91535
cce9153599308ca6feb100aa39637ac0f846eb65
change-id
ososkulq
ososkulqlukplqrsyxsmwnqrntrvkmkp
+141
-3
+14
Cargo.lock
+14
Cargo.lock
···
3171
3171
"url",
3172
3172
"wasm-bindgen",
3173
3173
"wasm-bindgen-futures",
3174
+
"wasm-streams",
3174
3175
"web-sys",
3175
3176
"webpki-roots",
3176
3177
]
···
4408
4409
checksum = "bad67dc8b2a1a6e5448428adec4c3e84c43e561d8c9ee8a9e5aabeb193ec41d1"
4409
4410
dependencies = [
4410
4411
"unicode-ident",
4412
+
]
4413
+
4414
+
[[package]]
4415
+
name = "wasm-streams"
4416
+
version = "0.4.2"
4417
+
source = "registry+https://github.com/rust-lang/crates.io-index"
4418
+
checksum = "15053d8d85c7eccdbefef60f06769760a563c7f0a9d6902a13d35c7800b0ad65"
4419
+
dependencies = [
4420
+
"futures-util",
4421
+
"js-sys",
4422
+
"wasm-bindgen",
4423
+
"wasm-bindgen-futures",
4424
+
"web-sys",
4411
4425
]
4412
4426
4413
4427
[[package]]
+3
-3
crates/jacquard-common/Cargo.toml
+3
-3
crates/jacquard-common/Cargo.toml
···
35
35
url.workspace = true
36
36
http.workspace = true
37
37
38
-
reqwest = { workspace = true, optional = true, features = ["charset", "gzip"] }
38
+
reqwest = { workspace = true, optional = true, features = ["charset", "gzip", "stream"] }
39
39
serde_ipld_dagcbor.workspace = true
40
40
signature = { version = "2", optional = true }
41
41
tracing = { workspace = true, optional = true }
···
43
43
44
44
# Streaming support (optional)
45
45
n0-future = { version = "0.1", optional = true }
46
+
futures = { version = "0.3", optional = true }
46
47
47
48
[target.'cfg(target_family = "wasm")'.dependencies]
48
49
getrandom = { version = "0.3.4", features = ["wasm_js"] }
···
59
60
service-auth = ["crypto-k256", "crypto-p256", "dep:signature"]
60
61
reqwest-client = ["dep:reqwest"]
61
62
tracing = ["dep:tracing"]
62
-
streaming = ["n0-future"]
63
+
streaming = ["n0-future", "futures"]
63
64
64
65
[dependencies.ed25519-dalek]
65
66
version = "2"
···
80
81
81
82
[dev-dependencies]
82
83
tokio = { version = "1", features = ["macros", "rt"] }
83
-
futures = "0.3"
84
84
85
85
[package.metadata.docs.rs]
86
86
features = [ "crypto-k256", "crypto-k256", "crypto-p256"]
+100
crates/jacquard-common/src/http_client.rs
+100
crates/jacquard-common/src/http_client.rs
···
17
17
) -> impl Future<Output = core::result::Result<http::Response<Vec<u8>>, Self::Error>>;
18
18
}
19
19
20
+
#[cfg(feature = "streaming")]
21
+
use crate::stream::{ByteStream, StreamError};
22
+
23
+
/// Extension trait for HTTP client with streaming support
24
+
#[cfg(feature = "streaming")]
25
+
#[cfg_attr(not(target_arch = "wasm32"), trait_variant::make(Send))]
26
+
pub trait HttpClientExt: HttpClient {
27
+
/// Send HTTP request and return streaming response
28
+
fn send_http_streaming(
29
+
&self,
30
+
request: http::Request<Vec<u8>>,
31
+
) -> impl Future<Output = Result<http::Response<ByteStream>, Self::Error>>;
32
+
33
+
/// Send HTTP request with streaming body and receive streaming response
34
+
fn send_http_bidirectional<S>(
35
+
&self,
36
+
parts: http::request::Parts,
37
+
body: S,
38
+
) -> impl Future<Output = Result<http::Response<ByteStream>, Self::Error>>
39
+
where
40
+
S: n0_future::Stream<Item = bytes::Bytes> + Send + 'static;
41
+
}
42
+
20
43
#[cfg(feature = "reqwest-client")]
21
44
impl HttpClient for reqwest::Client {
22
45
type Error = reqwest::Error;
···
77
100
self.as_ref().send_http(request)
78
101
}
79
102
}
103
+
104
+
#[cfg(all(feature = "streaming", feature = "reqwest-client"))]
105
+
impl HttpClientExt for reqwest::Client {
106
+
async fn send_http_streaming(
107
+
&self,
108
+
request: http::Request<Vec<u8>>,
109
+
) -> Result<http::Response<ByteStream>, Self::Error> {
110
+
// Convert http::Request to reqwest::Request
111
+
let (parts, body) = request.into_parts();
112
+
113
+
let mut req = self.request(parts.method, parts.uri.to_string()).body(body);
114
+
115
+
// Copy headers
116
+
for (name, value) in parts.headers.iter() {
117
+
req = req.header(name.as_str(), value.as_bytes());
118
+
}
119
+
120
+
// Send request and get streaming response
121
+
let resp = req.send().await?;
122
+
123
+
// Convert reqwest::Response to http::Response with ByteStream
124
+
let mut builder = http::Response::builder().status(resp.status());
125
+
126
+
// Copy headers
127
+
for (name, value) in resp.headers().iter() {
128
+
builder = builder.header(name.as_str(), value.as_bytes());
129
+
}
130
+
131
+
// Convert bytes_stream to ByteStream
132
+
use futures::StreamExt;
133
+
let stream = resp.bytes_stream().map(|result| {
134
+
result.map_err(|e| StreamError::transport(e))
135
+
});
136
+
let byte_stream = ByteStream::new(stream);
137
+
138
+
Ok(builder.body(byte_stream).expect("Failed to build response"))
139
+
}
140
+
141
+
async fn send_http_bidirectional<S>(
142
+
&self,
143
+
parts: http::request::Parts,
144
+
body: S,
145
+
) -> Result<http::Response<ByteStream>, Self::Error>
146
+
where
147
+
S: n0_future::Stream<Item = bytes::Bytes> + Send + 'static,
148
+
{
149
+
// Convert stream to reqwest::Body
150
+
use futures::StreamExt;
151
+
let ok_stream = body.map(Ok::<_, Self::Error>);
152
+
let reqwest_body = reqwest::Body::wrap_stream(ok_stream);
153
+
154
+
let mut req = self
155
+
.request(parts.method, parts.uri.to_string())
156
+
.body(reqwest_body);
157
+
158
+
// Copy headers
159
+
for (name, value) in parts.headers.iter() {
160
+
req = req.header(name.as_str(), value.as_bytes());
161
+
}
162
+
163
+
// Send and convert response
164
+
let resp = req.send().await?;
165
+
166
+
let mut builder = http::Response::builder().status(resp.status());
167
+
168
+
for (name, value) in resp.headers().iter() {
169
+
builder = builder.header(name.as_str(), value.as_bytes());
170
+
}
171
+
172
+
let stream = resp.bytes_stream().map(|result| {
173
+
result.map_err(|e| StreamError::transport(e))
174
+
});
175
+
let byte_stream = ByteStream::new(stream);
176
+
177
+
Ok(builder.body(byte_stream).expect("Failed to build response"))
178
+
}
179
+
}
+3
crates/jacquard-common/src/lib.rs
+3
crates/jacquard-common/src/lib.rs
+21
crates/jacquard-common/tests/http_streaming.rs
+21
crates/jacquard-common/tests/http_streaming.rs
···
1
+
#![cfg(all(feature = "streaming", feature = "reqwest-client"))]
2
+
3
+
use jacquard_common::http_client::HttpClientExt;
4
+
5
+
#[tokio::test]
6
+
async fn reqwest_client_can_stream_response() {
7
+
let client = reqwest::Client::new();
8
+
9
+
let request = http::Request::builder()
10
+
.uri("https://www.rust-lang.org/")
11
+
.body(vec![])
12
+
.unwrap();
13
+
14
+
let response = client.send_http_streaming(request).await.unwrap();
15
+
// Just verify we got a response - the fact that it didn't error means the streaming works
16
+
assert!(
17
+
response.status().is_success() || response.status().is_redirection(),
18
+
"Status: {}",
19
+
response.status()
20
+
);
21
+
}